-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conj function and adjoint tests #62
Conversation
What's the use-case for adding this? The only reason we have a |
Specifically for normal operators, e.g., in CG part |
Hmm. I think we can probably handle that without adding a new API. Rewriting this line: Mostly I'm trying to avoid adding more to the public API. We'd also then need to register rules for every downstream operator. |
I see the reasoning, but currently it's suggested that the user should do the adjoint themselves at least in some cases: Also, not having adjoint means bilinears are out of the question, if this is relevant. |
Hmm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits aside, this LGTM! Thank you for taking the time to make this happen.
By the way, let me know what your plan is regarding the various PRs. I think what might be easiest is to finish all of them before merging any of them, and then we can merge them in whatever order you think is best. (Some good news - I have no changes planned for Lineax at the moment, so you shouldn't need to worry about keeping any of them up to date with any other changes.) |
From my perspective, these 5 PRs are ready to merge (up to minor unclosed discussions). It does not fully implement complex support, but it would be simpler for me to continue when these are merged so I can be sure this part already works. As for the merge order, I think it should #59 and #63 should go first, then #60, then #61 and this one |
Also LGTM! |
Add adjoint property, which is useful for complex-valued operators.
See #57