Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix of docs in all three and a return type in quicsort #515

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

andyElking
Copy link
Contributor

@andyElking andyElking commented Oct 18, 2024

Noticed a few little issues while I was implementing UBU (for some unrelated work).

@patrick-kidger
Copy link
Owner

LGTM!

I was wondering why these didn't trigger an error in our documentation-building process, and it looks like we haven't actually included these solvers in the documentation at all! I'd missed that that was the case -- probably they are meant to be there?

@andyElking
Copy link
Contributor Author

I think they are present in the docs, at the bottom of sde_solvers.md. Maybe you don't build the docs on the dev branch?? To be fair I was very surprised this went unnoticed, since I did build the docs each time before committing (after you got me used to doing that). Not sure...

@patrick-kidger
Copy link
Owner

Ah, right! I was indeed just looking on the wrong branch, whoops.

I should probably do a new release -- once this PR is in I'll do so.

(And I'm aware thte the JumpStepWrapper implementation still needs my attention... I've been meaning to find some time to get back to that 😅)

@andyElking
Copy link
Contributor Author

No hurry with the JumpStepWrapper, I am done with what I needed it for – but of course I am happy to make edits once you review it. And also no hurry with a new release, as far as I'm concerned 😊.

I just saw that test_implicit_closure_convert failed for some reason, but I am confident that has nothing to do with my edits 😅. Also it passes fine when I run it locally.

@patrick-kidger
Copy link
Owner

patrick-kidger commented Oct 18, 2024

Yup, this is just JAX 0.4.34 doing its thing and breaking us all over the show :D I've now got PRs out for both Optimistix and Lineax, which is where the fixes need to be:

patrick-kidger/optimistix#87
patrick-kidger/lineax#111

@andyElking
Copy link
Contributor Author

Oh, I see. I don't envy you for having to fix that.

@patrick-kidger patrick-kidger merged commit 2e7836d into patrick-kidger:dev Oct 21, 2024
1 of 2 checks passed
@patrick-kidger
Copy link
Owner

Okay, merged! (All the new issues I know about have now been squashed!) Thanks for fixing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants