Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop HITL #814

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Prop HITL #814

wants to merge 7 commits into from

Conversation

govindchari
Copy link
Member

@govindchari govindchari commented Sep 25, 2021

Prop HITL

Fixes #802

Summary of changes

  • Adds ptest case for prop HITL
  • Adds hootl_hitl.json config

HITL only works if adcs_box_controller.execute() is commented out of main control loop.

Copy link
Member

@knk38 knk38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few doc stuff/ questions I had

"http_port" : 8089,
"imei": "412222222",
"scrape_uplinks": false,
"enable_auto_dbtelem": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this really matters, but this case works fine with telemetry on the hootl designated unit? I think I remember some issues with this

ptest/cases/propsystem_firing.py Outdated Show resolved Hide resolved
@@ -121,3 +121,7 @@ def cycle(self):
# device.scrape_uplink()
if device.enable_auto_dbtelem:
device.dbtelem()
def rs(self, name, print=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to note that we are designating follower to be the satellite that matters in this environment and the fact that we can only rs follower states

@shihaocao
Copy link
Collaborator

I think we can close this PR as we did complete this testing, but did not merge into final code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop System Firing HITL
3 participants