Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-33683) feat(NC): remove getExchangeRates from firestore #7533

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

lbeneston-pass
Copy link
Contributor

@lbeneston-pass lbeneston-pass commented Jan 16, 2025

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-33683

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion
  • I am aware of all the best practices and respected them.

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome Capture d’écran 2025-01-17 à 12 08 46

@lbeneston-pass lbeneston-pass force-pushed the PC-33683 branch 2 times, most recently from 3192832 to a5f33ef Compare January 16, 2025 16:53
@lbeneston-pass lbeneston-pass changed the title (PC-33683) (PC-33683) feat(NC): remove getExchangeRates Jan 16, 2025
@lbeneston-pass lbeneston-pass changed the title (PC-33683) feat(NC): remove getExchangeRates (PC-33683) feat(NC): remove getExchangeRates from firestore Jan 16, 2025
@lbeneston-pass lbeneston-pass force-pushed the PC-33683 branch 4 times, most recently from a8ab22a to 297c39c Compare January 17, 2025 11:08
@lbeneston-pass lbeneston-pass merged commit 71a99bd into master Jan 17, 2025
53 checks passed
@lbeneston-pass lbeneston-pass deleted the PC-33683 branch January 17, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants