Skip to content

Commit

Permalink
(PC-34012) fix(ui): 2 lines title on iOS in ContentHeader + improveme…
Browse files Browse the repository at this point in the history 
…nts (#7526)

* (PC-34012) fix(ui): 2 lines title on iOS in ContentHeader

* (PC-34012) refactor(headers): remove Spacer.Row and Column in ContentHeader

* (PC-34012) feat(ui): ContentHeader code improvements

* (PC-34012) test(ui): regenerate snapshots

* (PC-34012) refactor(ui): remove Spacer.TopScreen of ContentHeader

* (PC-34012) refactor(ui): remove Spacer.Flex of ContentHeader
  • Loading branch information
@clesausse-pass
clesausse-pass authored Jan 20, 2025
1 parent 4c32cf2 commit 5bffa89
Show file tree
Hide file tree
Showing 6 changed files with 227 additions and 562 deletions.
119 changes: 31 additions & 88 deletions ...shots__/features/bookings/pages/BookingDetails/BookingDetails.native.test.tsx.native-snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1088,17 +1088,6 @@ exports[`BookingDetails should render correctly 1`] = `
}
}
>
<View
customHeight={16}
enable={true}
style={
[
{
"height": 16,
},
]
}
/>
<View
collapsable={false}
height={80}
Expand Down Expand Up @@ -1134,38 +1123,22 @@ exports[`BookingDetails should render correctly 1`] = `
/>
</View>
<View
numberOfSpaces={2}
style={
[
{
"height": 8,
},
]
}
/>
<View
marginRight={64}
marginTop={16}
style={
[
{
"alignItems": "center",
"flexBasis": 0,
"flexDirection": "row",
"flexGrow": 1,
"flexShrink": 1,
"justifyContent": "space-between",
"marginBottom": 8,
"marginLeft": 24,
"marginRight": 64,
"marginTop": 16,
},
]
}
>
<View
numberOfSpaces={6}
style={
[
{
"width": 24,
},
]
}
/>
<View
accessibilityLabel="Revenir en arrière"
accessibilityRole="button"
Expand Down Expand Up @@ -1288,67 +1261,37 @@ exports[`BookingDetails should render correctly 1`] = `
},
]
}
/>
<Text
accessibilityHidden={true}
collapsable={false}
numberOfLines={2}
style={
{
"color": "#ffffff",
"flexShrink": 1,
"opacity": 0,
"textAlign": "center",
}
}
>
<Text
accessibilityHidden={true}
collapsable={false}
numberOfLines={2}
style={
[
{
"color": "#161617",
"fontFamily": "Montserrat-Medium",
"fontSize": 16,
"lineHeight": 25.6,
},
]
{
"color": "#ffffff",
"flexShrink": 1,
"opacity": 0,
"textAlign": "center",
}
}
>
Avez-vous déjà vu ?
<Text
style={
[
{
"color": "#161617",
"fontFamily": "Montserrat-Medium",
"fontSize": 16,
"lineHeight": 25.6,
},
]
}
>
Avez-vous déjà vu ?
</Text>
</Text>
</Text>
<View
style={
[
{
"flexBasis": 0,
"flexGrow": 1,
"flexShrink": 1,
},
]
}
/>
<View
numberOfSpaces={16}
style={
[
{
"width": 64,
},
]
}
/>
</View>
</View>
<View
numberOfSpaces={2}
style={
[
{
"height": 8,
},
]
}
/>
</View>
<Modal
accessibilityLabelledBy="testUuidV4"
Expand Down
119 changes: 31 additions & 88 deletions __snapshots__/features/home/pages/ThematicHome.native.test.tsx.native-snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -348,17 +348,6 @@ exports[`ThematicHome should render correctly 1`] = `
}
}
>
<View
customHeight={16}
enable={true}
style={
[
{
"height": 16,
},
]
}
/>
<View
collapsable={false}
height={80}
Expand Down Expand Up @@ -394,38 +383,22 @@ exports[`ThematicHome should render correctly 1`] = `
/>
</View>
<View
numberOfSpaces={2}
style={
[
{
"height": 8,
},
]
}
/>
<View
marginRight={24}
marginTop={16}
style={
[
{
"alignItems": "center",
"flexBasis": 0,
"flexDirection": "row",
"flexGrow": 1,
"flexShrink": 1,
"justifyContent": "space-between",
"marginBottom": 8,
"marginLeft": 24,
"marginRight": 24,
"marginTop": 16,
},
]
}
>
<View
numberOfSpaces={6}
style={
[
{
"width": 24,
},
]
}
/>
<View
accessibilityLabel="Revenir en arrière"
accessibilityRole="button"
Expand Down Expand Up @@ -548,46 +521,36 @@ exports[`ThematicHome should render correctly 1`] = `
},
]
}
/>
<Text
accessibilityHidden={true}
collapsable={false}
numberOfLines={2}
style={
{
"color": "#ffffff",
"flexShrink": 1,
"opacity": 0,
"textAlign": "center",
}
}
>
<Text
accessibilityHidden={true}
collapsable={false}
numberOfLines={2}
style={
[
{
"color": "#161617",
"fontFamily": "Montserrat-Medium",
"fontSize": 16,
"lineHeight": 25.6,
},
]
{
"color": "#ffffff",
"flexShrink": 1,
"opacity": 0,
"textAlign": "center",
}
}
>
HeaderTitle
<Text
style={
[
{
"color": "#161617",
"fontFamily": "Montserrat-Medium",
"fontSize": 16,
"lineHeight": 25.6,
},
]
}
>
HeaderTitle
</Text>
</Text>
</Text>
<View
style={
[
{
"flexBasis": 0,
"flexGrow": 1,
"flexShrink": 1,
},
]
}
/>
</View>
<View
collapsable={false}
style={
Expand Down Expand Up @@ -797,27 +760,7 @@ exports[`ThematicHome should render correctly 1`] = `
/>
</View>
</View>
<View
numberOfSpaces={6}
style={
[
{
"width": 24,
},
]
}
/>
</View>
<View
numberOfSpaces={2}
style={
[
{
"height": 8,
},
]
}
/>
</View>
<View
collapsable={false}
Expand Down
Loading

0 comments on commit 5bffa89

Please sign in to comment.