Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: system parachain chain spec generator #149

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

AlexD10S
Copy link
Collaborator

When running pop up parachain with the latest paseo release (v1.3.1) I was getting an issue generating the chain-spec. Comparing the old one generated (v1.2.6) with the new one I noticed the difference was with the id:

"name": "Asset Hub Paseo Local",
"id": "asset-hub-paseo-local"

vs

“name": "Paseo Asset Hub Local",
"id": "paseo-asset-hub-local",

Fixed to use asset-hub-paseo-local.

@pecorino-bot
Copy link

pecorino-bot commented Oct 30, 2024

Tests have finished.

Build

Status: success

Relay Chain

Status: failure

System Parachains

Status: success

Integration Tests

Status: failure

❌ Some tests have failed. Please check the details above for more information.

View full run details

@al3mart
Copy link
Contributor

al3mart commented Oct 30, 2024

The change was introduced to avoid matching with any of the included spec ids in the sdk ChainSpecLoader. So that the spec names would start with paseo and not match any other asset-hub* posible value.
Every spec was adapted. You can see that all the spec ids here start with paseo - https://github.com/paseo-network/paseo-chain-specs

Let's revisit if that is not the case anymore and follow up accordingly here.

@hbulgarini hbulgarini merged commit 6808879 into main Oct 30, 2024
1 check passed
al3mart added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants