Skip to content

Commit

Permalink
ci-fixes on dumpLogs map before allSettled (#1885)
Browse files Browse the repository at this point in the history
* ci-fixes, on dumpLogs map before allSettled

* lint
  • Loading branch information
pepoviola authored Oct 1, 2024
1 parent 7f69828 commit b586dfb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
10 changes: 6 additions & 4 deletions javascript/packages/orchestrator/src/network.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,12 @@ export class Network {
[],
);

const dumpsPromises = this.relay.concat(paraNodes).map((node) => {
this.client.dumpLogs(this.tmpDir, node.name);
});
await Promise.allSettled(dumpsPromises);
const dumpsNodes = this.relay.concat(paraNodes);
await Promise.allSettled(
dumpsNodes.map((node) => {
this.client.dumpLogs(this.tmpDir, node.name);
}),
);

if (showLogPath)
new CreateLogTable({ colWidths: [20, 100] }).pushToPrint([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,7 @@ export class KubeClient extends Client {
// We should read it from host filesystem to ensure we are reading all the logs.

// First get the logs files to check if we need to read from disk or not
debugLogs("getting logFiles for:", podName);
const logFiles = await this.gzippedLogFiles(podName);
debugLogs("logFiles", logFiles);
let logs = "";
Expand Down

0 comments on commit b586dfb

Please sign in to comment.