Attempt to quickfix flaky legacy_and_unstable_block_subscription_reconnect #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Nov 15, 2024
niklasad1
reviewed
Nov 15, 2024
niklasad1
reviewed
Nov 15, 2024
| @@ -412,7 +412,7 @@ async fn partial_fee_estimate_correct() { | |||
| assert_eq!(partial_fee_1, partial_fee_2); | |||
| } | |||
|
|
|||
| #[subxt_test] | |||
| #[subxt_test(timeout = 120)] | |||
There was a problem hiding this comment.
starting/restarting the substrate node can be quite slow sometimes, I would rather go with five minutes (300 secs)
Co-authored-by: Niklas Adolfsson <[email protected]>
jsdw
commented
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doubling the timeout.
This test passes locally reliably in 25-30s so maybe just slow runners?