Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subxt: when native feature is enabled, we need polkadot-sdk/std for eg examples to work #1864

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Nov 12, 2024

Without this, commands like the following will fail:

cd subxt && cargo run --example light_client_local_node --features unstable-light-client    

This because when "std" is not enabled on "polkadot-sdk", it assumes it's compiling for WASM

@jsdw jsdw requested a review from a team as a code owner November 12, 2024 17:57
@jsdw jsdw changed the title When native feature is enabled, we need polkadot-sdk/std for eg examples to work subxt: when native feature is enabled, we need polkadot-sdk/std for eg examples to work Nov 12, 2024
@jsdw jsdw merged commit f861adf into master Nov 13, 2024
13 checks passed
@jsdw jsdw deleted the jsdw-fix-examples branch November 13, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants