Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Autonomys network #227

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

dariolina
Copy link
Contributor

Added Autonomys network (https://www.autonomys.xyz/) and bumped minor version to "1.51.0"

@dariolina
Copy link
Contributor Author

Hi @bkchr @SBalaguer
I understand that Parity is looking to revamp the registry, however, we are looking to launch Autonomys mainnet within a few weeks (blog) so would greatly appreciate a review and release of this crate.
Thank you for understanding!

@SBalaguer
Copy link

@dariolina all looks good to me, however I do have a question: Isn't Autonomys a rebranding of Subpsace, and so you wouldn't need a new SS58 but rather a modification of the previous one? Or are you keeping both blockchains running simultaneously?

Also as you said, there's a discussion going on in the ecosystem regarding ss58, so this registry might be shut down in the future.

@dariolina
Copy link
Contributor Author

@SBalaguer thanks for a speedy response!
Indeed, it is a rebranding of Subspace, but adding a new entry kind of felt less invasive. Happy to modify.

@SBalaguer
Copy link

I see! Then if it's a rebranding and you're using the same chain as you have today, you can go ahead and modify the existing entry. If subspace won't exist as it used to anymore, this is probably the best.

@SBalaguer
Copy link

thanks @dariolina! @bkchr this looks good to me to merge.

@dariolina
Copy link
Contributor Author

Thanks for the review @bkchr ! Is there anything I need to do to get this merged and released to crates?

@bkchr
Copy link
Member

bkchr commented Oct 6, 2024

@dariolina please merge master to make this pr mergable.

@bkchr bkchr merged commit 57344a5 into paritytech:main Oct 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants