Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CSV related tools to master #69

Merged
merged 6 commits into from
May 3, 2024

Conversation

karolk91
Copy link
Contributor

@karolk91 karolk91 commented May 1, 2024

Add a CSV creation script that parses smart-bench logs and converts them into entries in CSV format

stats/README.md Outdated Show resolved Hide resolved
launch/README.md Outdated Show resolved Hide resolved
@@ -130,17 +130,40 @@ docker run --rm -it --init -v $PWD/configs:/usr/local/smart-bench/config smart-b
---

## Miscellaneous

Copy link
Contributor

@smiasojed smiasojed May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using prefunded account on master - master is compatible with polkadot 1.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove the section, thanks for spotting this

@smiasojed
Copy link
Contributor

smiasojed commented May 1, 2024

I would like to keep master compatible with polkadot v1.0.0, once we merge the csv generation script I will move the tag v1.0.0 to head of master.
We will keep the polkadot version v1.7.0 on v1.7.0 branch

launch/README.md Outdated Show resolved Hide resolved

Final image consists of few pieces that are integrated into it:
- `polkadot`, `zombienet` and `polkadot-parachain` pre-compiled binaries taken from offical releases
- `polkadot`, `polkadot-parachain`, `polkadot-execute-worker`, `polkadot-prepare-worker` and `zombienet` pre-compiled binaries taken from offical releases
- `moonbeam` binary provided by custom release created on [this fork](https://github.com/karolk91/moonbeam) (custom fork was required to enable dev rpc module which is not supported by offical releases)
Copy link
Contributor

@smiasojed smiasojed May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which moonbeam branch is compatible with polkadot v1.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its the same moonbeam version for both branches

@@ -0,0 +1,75 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could add output-csv option to smart-bench?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thats good idea, we can think of this pull request as some intermediate step towards better solution

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, lets create an issue for improvement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this might be a better idea just to add the option to output as csv to smart-bench itself.

@karolk91 karolk91 changed the title Introduce CSV related tools Introduce CSV related tools to master May 2, 2024
@karolk91 karolk91 requested review from ascjones and a team as code owners May 2, 2024 20:52
@@ -0,0 +1,75 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this might be a better idea just to add the option to output as csv to smart-bench itself.

@smiasojed smiasojed merged commit 7918e96 into paritytech:master May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants