-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CSV related tools to master #69
Conversation
@@ -130,17 +130,40 @@ docker run --rm -it --init -v $PWD/configs:/usr/local/smart-bench/config smart-b | |||
--- | |||
|
|||
## Miscellaneous | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using prefunded account on master - master is compatible with polkadot 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove the section, thanks for spotting this
I would like to keep master compatible with polkadot v1.0.0, once we merge the csv generation script I will move the tag v1.0.0 to head of master. |
|
||
Final image consists of few pieces that are integrated into it: | ||
- `polkadot`, `zombienet` and `polkadot-parachain` pre-compiled binaries taken from offical releases | ||
- `polkadot`, `polkadot-parachain`, `polkadot-execute-worker`, `polkadot-prepare-worker` and `zombienet` pre-compiled binaries taken from offical releases | ||
- `moonbeam` binary provided by custom release created on [this fork](https://github.com/karolk91/moonbeam) (custom fork was required to enable dev rpc module which is not supported by offical releases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which moonbeam branch is compatible with polkadot v1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its the same moonbeam version for both branches
@@ -0,0 +1,75 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we could add output-csv option to smart-bench?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, thats good idea, we can think of this pull request as some intermediate step towards better solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, lets create an issue for improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this might be a better idea just to add the option to output as csv to smart-bench itself.
Co-authored-by: Sebastian Miasojed <[email protected]>
@@ -0,0 +1,75 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this might be a better idea just to add the option to output as csv to smart-bench itself.
Add a CSV creation script that parses smart-bench logs and converts them into entries in CSV format