This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Add sign & verify methods w/ signing context param. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2019
|
Your derives tests look like test vectors. We've no test vectors yet because the scheme was not stable w3f/schnorrkel#36 In this case, there were so many breaking changes between 0.1.1 and 0.6.1 that any test vector anywhere should've broken. We're starting an audit this week, which might result in the final breaking changes, so test vectors may become reasonable in early August. |
|
The failing tests are unrelated to this PR. If it's not a problem I'm sure I can just update the expected output for each and make them pass again. PS, any idea how |
|
It looks like it's dose some sort of functionality tests I guess. I'm not sure about the js stuff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12
Introduces signing context interfaces for sign and verify while maintaining back compatibility. Might be an interface to consolidate in a later version.
The upgrade of schnorrkel 0.1 to 0.6 seems to have broken the derives tests. Need guidance on how to proceed.