[pallet-broker] Fix auto renew benchmarks #6505
Draft
+101
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
added
T2-pallets
|
/cmd prdoc --audience runtime_dev --bump minor |
seadanda
commented
Nov 15, 2024
| let region = Broker::<T>::do_purchase(caller.clone(), 10u32.into()) | ||
| .map_err(|_| BenchmarkError::Weightless)?; | ||
| let region = Broker::<T>::do_purchase(caller.clone(), 10_000_000u32.into()) | ||
| .expect("Offer not high enough for configuration."); |
There was a problem hiding this comment.
Since we advance to the fixed price phase, this is independent of the price adapter implementation and depends only on the config value set earlier in this file. Therefore it's better to unwrap here so the test fails, rather than always being mapped to Weightless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the broker pallet auto-renew benchmarks which have been broken since #4424, yielding
Weightlessdue to some prices being set too low, as reported in #6474.Upon further investigation it turned out that the auto-renew contribution to
rotate_salewas always failing but the error was mapped. This is also fixed at the cost of a bit of setup overhead.Fixes #6474
TODO: