Mention that account might still be required in doc for feeless if. #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Nov 15, 2024
bkchr
reviewed
Nov 15, 2024
substrate/frame/support/src/lib.rs
Outdated
| /// extension such as [`pallet_skip_feeless_payment::SkipCheckIfFeeless`] to wrap the | ||
| /// existing payment extension. Else, this is completely ignored and the dispatchable is | ||
| /// still charged. | ||
| /// | ||
| /// Also this will not allow accountless caller to send a transaction if some transaction | ||
| /// extension such as [`frame_system::CheckNonce`] is used. |
There was a problem hiding this comment.
The intra doc links should not work or? Because frame_system isn't a dependency?
There was a problem hiding this comment.
Indeed, I removed the link. Somehow I thought dev-dependencies were also in scope.
gupnik
approved these changes
Nov 15, 2024
georgepisaltu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.