Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network/litep2p: Update litep2p network backend to version 0.8.1 #6484

Merged
merged 3 commits into from
Nov 15, 2024
+22 −6
Merged

network/litep2p: Update litep2p network backend to version 0.8.1 #6484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2988557
cargo: Update litep2p to version 0.8.1
lexnv Nov 14, 2024
41c23a3
litep2p: Log error and terminate network runner on litep2p
lexnv Nov 14, 2024
ff8b67b
docs: Add prdoc
lexnv Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ linked-hash-map = { version = "0.5.4" }
linked_hash_set = { version = "0.1.4" }
linregress = { version = "0.5.1" }
lite-json = { version = "0.2.0", default-features = false }
litep2p = { version = "0.8.0", features = ["websocket"] }
litep2p = { version = "0.8.1", features = ["websocket"] }
log = { version = "0.4.22", default-features = false }
macro_magic = { version = "0.5.1" }
maplit = { version = "1.0.2" }
Expand Down
10 changes: 10 additions & 0 deletions prdoc/pr_6484.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
title: Update litep2p network backend to version 0.8.1

doc:
- audience: [ Node Dev, Node Operator ]
description: |
Release 0.8.1 of litep2p includes critical fixes to further enhance the stability and performance of the litep2p network backend.

crates:
- name: sc-network
bump: patch
8 changes: 7 additions & 1 deletion substrate/client/network/src/litep2p/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,7 +1074,13 @@ impl<B: BlockT + 'static, H: ExHashT> NetworkBackend<B, H> for Litep2pNetworkBac
metrics.pending_connections_errors_total.with_label_values(&["transport-errors"]).inc();
}
}
_ => {}
None => {
log::error!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes only when it is terminated and not shutdown gracefully?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked with a stopped polkadot node and litep2p backend, we don't seem to emit errors here

target: LOG_TARGET,
"Litep2p backend terminated"
);
return
}
},
}
}
Expand Down
Loading