archive: Refactor archive_storage method into subscription
#6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
instead Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
R0-silent
niklasad1
reviewed
Nov 14, 2024
|
|
||
| /// Sends all the events to the sink. | ||
| async fn process_storage_events(rx: &mut mpsc::Receiver<QueryResult>, sink: &mut Subscription) { | ||
| while let Some(event) = rx.recv().await { |
There was a problem hiding this comment.
perhaps do a select loop here instead to terminate this when the subscription is closed, just to be on the safe side if the connection gets idle after getting being backpressured and no events are emitted....
loop {
tokio::select! {
_ = sink.closed() => return,
event = rx.recv() => { // code to read the event here }
}
}
niklasad1
reviewed
Nov 15, 2024
| @@ -57,42 +59,12 @@ use tokio::sync::mpsc; | |||
|
|
|||
| pub(crate) const LOG_TARGET: &str = "rpc-spec-v2::archive"; | |||
|
|
|||
| /// The configuration of [`Archive`]. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the
archive_storageimplementation from a method to a subscription.This keeps the archive APIs uniform and consistent.
Builds on: #5997
cc @paritytech/subxt-team