Update Pallet Referenda to support Block Number Provider #6338
+48
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Nov 4, 2024
| @@ -239,6 +240,9 @@ pub mod pallet { | |||
|
|
|||
| /// The preimage provider. | |||
| type Preimages: QueryPreimage<H = Self::Hashing> + StorePreimage; | |||
|
|
|||
| /// Provider for the block number. Normally this is the `frame_system` pallet. | |||
| type BlockNumberProvider: BlockNumberProvider<BlockNumber = BlockNumberFor<Self>>; | |||
There was a problem hiding this comment.
Why do we force the block number to be the one in system?
If the block number provider is RelayChainDataProvider, then the block number can be different.
It would be more clean to keep it generic here.
Then we should use a new type:
type BlockNumberFor<T> = <<Self as Config>::BlockNumberProvider as BlockNumberProvider>::BlockNumber;
Suggested change
| type BlockNumberProvider: BlockNumberProvider<BlockNumber = BlockNumberFor<Self>>; | |
| type BlockNumberProvider: BlockNumberProvider; |
There was a problem hiding this comment.
Yeah, we should not require the same block number type.
There was a problem hiding this comment.
@gui1117 shouldn't it be
pub type BlockNumberFor<T, I> = <<T as Config<I>>::BlockNumberProvider as BlockNumberProvider>::BlockNumber;
since the referenda pallet is an Instantiable one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BlockNumberProvider config for the referenda pallet.
closes part of #6297