-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-utility: if_else
#6321
Open
rainbow-promise
wants to merge
14
commits into
paritytech:master
Choose a base branch
from
rainbow-promise:if-else-utility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pallet-utility: if_else
#6321
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b83a8e8
extrinsic outline
rainbow-promise 1b01dc9
new: outline utility_if_else
rainbow-promise 430a791
do not clone calls
rainbow-promise 2caf95e
compiler needs to know the size, put in Box
rainbow-promise 4183c6b
siimple test cases
rainbow-promise e70a607
if_else::benchmarking
rainbow-promise a93b142
add weights substrate
rainbow-promise cc79306
add weight to all runtimes
rainbow-promise 007d1c3
add prdoc
rainbow-promise 7f2c600
Merge branch 'master' into if-else-utility
rainbow-promise f2bd937
check CI event not emitted
rainbow-promise ad9e68b
DispatchErrorWithPostInfo
rainbow-promise 5ef6752
conditional Dispatch class
rainbow-promise 1d01444
nit DispatchClass
rainbow-promise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no string in pallets, the current implementation make it hard for sdk users to figure out the meaning of this
it could be an enum
but I don’t think the current event make sense as there are only 3 possibilities: main success, mail failed + fallback success, all failed
the all failed case should just result the whole call to be failed. ie no extra event. so we only really two event: main success, and fallback called