feat: @font-feature-values #840

CGQAQ · 2024-10-18T03:16:40Z

Closes: #837

src/parser.rs

src/lib.rs

src/rules/font_feature_values.rs

src/parser.rs

src/lib.rs

CGQAQ · 2024-11-15T08:43:38Z

Just addressed all issues, PTAL

…fied

devongovett · 2025-01-01T05:43:59Z

Thanks! I refactored this slightly to handle:

Using a custom type for declarations so they are fully parsed. With DeclarationBlock they'd all be parsed as unknown properties, and things like !important shouldn't be allowed.
Removed the font-display since it is not supported by any browser and will be removed from the spec.
Refactored FontFamily to separate FamilyName from generic family parsing. Generic families shouldn't be allowed here.
Handled merging duplicate declarations and rules.

CGQAQ commented Oct 18, 2024

View reviewed changes

src/parser.rs Show resolved Hide resolved

CGQAQ commented Oct 18, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

devongovett reviewed Nov 3, 2024

View reviewed changes

CGQAQ requested a review from devongovett November 15, 2024 08:43

CGQAQ added 6 commits January 1, 2025 00:39

feat: @font-feature-values

e4d64a1

fix: compilation error when cargo test with --all-features flag speci…

de9981d

…fied

feat: @font-feature-values

da329c5

fix: use FontFamily instead and run cargo fmt

3ac43d1

fix: ci failures

adc4132

fix: ci failures

0c9d65a

devongovett force-pushed the font-feature-values branch from 7604e11 to e445c51 Compare January 1, 2025 05:39

refactoring

79b544c

devongovett force-pushed the font-feature-values branch from e445c51 to 79b544c Compare January 1, 2025 05:43

devongovett merged commit 4cffb66 into parcel-bundler:master Jan 1, 2025
3 checks passed

CGQAQ deleted the font-feature-values branch January 2, 2025 00:54

Provide feedback