Fixes issue wrong max size in some sized buffer types. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
force-pushed
the
buffer-max-size-bug
branch
from
65258c9
to
8d19bf2
Compare
Some of the sized buffers had their buffer sizes set as numbers. Even though this in some cases were the correct numbers they were a little hard to determine if they actually followed the size specified in the standard. So this PR fixes parallaxsecond#548 in the main branch by using the the calculations specified in the standard for the buffer sizes. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
buffer-max-size-bug
branch
from
8d19bf2
to
bf24797
Compare
ionut-arm
approved these changes
Sep 27, 2024
Comment on lines
+6
to
+15
| fn test_max_sized_ecc_parameter_conversions() { | ||
| let expected_secret = [0xffu8; EncryptedSecret::MAX_SIZE]; | ||
| let native = EncryptedSecret::try_from(expected_secret.as_slice().to_vec()).expect( | ||
| "It should be possible to convert an array of MAX size into a EncryptedSecret object.", | ||
| ); | ||
| let tss = TPM2B_ENCRYPTED_SECRET::from(native); | ||
| assert_eq!(EncryptedSecret::MAX_SIZE, tss.size as usize); | ||
| // This will be a compiler error if the max size does not match the TSS buffer size. | ||
| assert_eq!(expected_secret, tss.secret); | ||
| } |
There was a problem hiding this comment.
I guess in the future we can make a macro out of this sort of test.
wiktor-k
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the sized buffers had their buffer sizes
set as numbers. Even though this in some cases
were the correct numbers they were a little hard
to determine if they actually followed the size
specified in the standard. So this PR fixes #548
in the main branch by using the the calculations
specified in the standard for the buffer sizes.