Improves tests for tagged schemes. #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
force-pushed
the
tagged-schemes-tests
branch
from
7f7e339
to
2b3419b
Compare
Superhepper
force-pushed
the
tagged-schemes-tests
branch
from
2b3419b
to
5f08a7c
Compare
ionut-arm
approved these changes
Sep 11, 2023
tss-esapi/tests/integration_tests/structures_tests/tagged_tests/tagged_ecc_scheme_tests.rs
Show resolved
Hide resolved
tss-esapi/tests/integration_tests/structures_tests/tagged_tests/tagged_ecc_scheme_tests.rs
Show resolved
Hide resolved
...esapi/tests/integration_tests/structures_tests/tagged_tests/tagged_signature_scheme_tests.rs
Outdated
Show resolved
Hide resolved
Superhepper
force-pushed
the
tagged-schemes-tests
branch
from
5f08a7c
to
0f732b8
Compare
wiktor-k
approved these changes
Sep 14, 2023
- Adds a file for tests for each individual tagged scheme and adds more tests for each type in ```tss-esapi/src/structures/tagged/schemes.rs```. - Adds missing support for `Hmac` variant when using `signing_scheme` and `set_signing_scheme` methods. - Changes name of variable holding the signing scheme. - Refactors the tagged signature scheme tests. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
tagged-schemes-tests
branch
from
0f732b8
to
08dc99a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a file for tests for each individual tagged scheme and adds more tests for each type in
tss-esapi/src/structures/tagged/schemes.rs.Adds missing support for
Hmacvariant when usingsigning_schemeandset_signing_schememethods.Changes name of variable holding the signing scheme.
Refactors the tagged signature scheme tests.