Fixes problem with lint warnings in different versions of Rust. #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. 👍 I think it would be good to have an actual CI job that'd use the oldest version of Rust compiler that we support thus verifying that this change does what it claims to do. (Or maybe it is already implemented... can't quickly check on mobile 😔) |
|
I have already made a MSRV job. It is one of the checks that must be ok before you can merge a PR. |
- The crate supports several different versions of rust and in some of these versions the Clippy lint tool introduces new warnings that are not present in previous versions of rust. This causes a warning when compiling. This has been fixed in this commit by using the `rustversion` crate to only add the lint if the crate is being built with a version of Rust that has it. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
lint-problems
branch
from
5a8c7b6
to
8d47806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustversioncrate to only add the lint if the crate is being built with a version of Rust that has it.