Adds strum as a integration test requirement. #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it something like this that you had in mind @wiktor-k ? |
|
Yeah the test code got significantly smaller. There's a slight cost of setup that I think we'd pay only once and then all similar tests can just reuse what you did here. 👍 I see that the CI complains about MSRV thought :/ |
Superhepper
force-pushed
the
main
branch
5 times, most recently
from
b9bb16a
to
2f18cac
Compare
-Adds integration-test feature in order to conditionally add dependencies. -Updates the TpmFormatZeroWarning so it is possible to iterate over all the items when creating integration tests. Signed-off-by: Jesper Brynolf <[email protected]>
That was just because I thought I was going to be clever and update a dependency. |
wiktor-k
approved these changes
Jul 30, 2023
ionut-arm
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adds integration-test feature in order to conditionally add
dependencies.
-Updates the TpmFormatZeroWarning so it is possible to iterate over all
the items when creating integration tests.