Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for hmac #417

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Firstyear
Copy link
Contributor

Relates to #21 - This adds an example of how to create a loadable hmac key.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! The example looks useful overall, left a few small clarity-related comments

tss-esapi/Cargo.toml Show resolved Hide resolved
tss-esapi/examples/hmac.rs Show resolved Hide resolved
tss-esapi/examples/hmac.rs Outdated Show resolved Hide resolved
tss-esapi/examples/hmac.rs Outdated Show resolved Hide resolved
tss-esapi/examples/hmac.rs Outdated Show resolved Hide resolved
@Firstyear
Copy link
Contributor Author

Hey @ionut-arm I think I've resolved everything here. Is this good to go now? I wanted to start to add some more examples soon :)

@ionut-arm
Copy link
Member

Ah, apologies! One more thing that would be needed is to address the clippy and formatting errors that are failing the CI. It might be needed to rebase on top of main to get everything green, I think there are some fixes there for some clippy issues.

@Firstyear
Copy link
Contributor Author

All good, happy to do that today. Didn't know if the project wanted me to run fmt/clippy :)

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR. I think it looks good.

Don't forget that all the commits in the PR needs to be signed otherwise the DCO check will fail.

@Firstyear
Copy link
Contributor Author

Thank you for reviewing! I plan to add more examples and might need some more help and advice in the process :)

@wiktor-k
Copy link
Collaborator

wiktor-k commented Aug 2, 2023

All good, happy to do that today. Didn't know if the project wanted me to run fmt/clippy :)

I think it'd be best if you just squashed all commits, rebased on top of master, and added Signed-off-by line to that single commit.

I'm on mobile so it's hard to me to find a one liner to do that but if you have problems please say we may collectively find something :)

Signed-off-by: William Brown <[email protected]>
@Firstyear
Copy link
Contributor Author

Done!

@ionut-arm ionut-arm merged commit 2b643f1 into parallaxsecond:main Aug 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants