-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for hmac #417
Add example for hmac #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! The example looks useful overall, left a few small clarity-related comments
Hey @ionut-arm I think I've resolved everything here. Is this good to go now? I wanted to start to add some more examples soon :) |
Ah, apologies! One more thing that would be needed is to address the clippy and formatting errors that are failing the CI. It might be needed to rebase on top of |
All good, happy to do that today. Didn't know if the project wanted me to run fmt/clippy :) |
8bb15b8
to
52095a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR. I think it looks good.
Don't forget that all the commits in the PR needs to be signed otherwise the DCO check will fail.
Thank you for reviewing! I plan to add more examples and might need some more help and advice in the process :) |
I think it'd be best if you just squashed all commits, rebased on top of master, and added Signed-off-by line to that single commit. I'm on mobile so it's hard to me to find a one liner to do that but if you have problems please say we may collectively find something :) |
Signed-off-by: William Brown <[email protected]>
ee8dc03
to
dd3f59e
Compare
Done! |
Relates to #21 - This adds an example of how to create a loadable hmac key.