Update examples #11
Update examples #11
Conversation
There was a problem hiding this comment.
Some general comments. I know we briefly discussed whether to include prefix command support in the server, but if it helps, this intro was originally designed to help people create slash commands using the various frameworks. Prefix commands were not considered at the time. What are your current thoughts on adding prefix command stuff?
| .add_field(name="Bot?", value=str(self.target.is_bot), inline=True) | ||
| .add_field(name="No. of roles", value=str(len(roles)), inline=True) |
There was a problem hiding this comment.
I believe these string casts are unnecessary.
There was a problem hiding this comment.
They are unnecessary (it's just to stop vscode's linter showing an error), but I'll remove them
There was a problem hiding this comment.
They don't normally show errors for me. Which linter are you using?
| colour=hikari.Colour(0x563275), | ||
| # Doing it like this is important. | ||
| timestamp=dt.datetime.now().astimezone(), | ||
| ) | ||
| .set_author(name="Information") | ||
| .set_author(name=str(self.target)) |
There was a problem hiding this comment.
Should this not use the display_name attribute?
There was a problem hiding this comment.
It'll show the user's username and discriminator, but I can use the display_name property if you'd like
There was a problem hiding this comment.
Ah okay. In that case it's fine as is.
| roles = (await self.target.fetch_roles())[1:] # All but @everyone. | ||
|
|
||
| # Create a list of roles, formatting them into role mentions. | ||
| # The @everyone role's ID is the guild's ID, which we filter out. |
There was a problem hiding this comment.
| # The @everyone role's ID is the guild's ID, which we filter out. | |
| # The @everyone role's ID is the guild's ID, which we filter out. |
|
|
||
| # Function calls can be chained when creating embeds. | ||
| embed = ( | ||
| hikari.Embed( | ||
| title="User information", | ||
| description=f"ID: {self.target.id}", | ||
| description=f"ID: `{self.target.id}`", |
There was a problem hiding this comment.
Imo, using backticks around Discord IDs is non-standard.
There was a problem hiding this comment.
I always use them, but I'll remove them
| INTENTS = ( | ||
| Intents.ALL_MESSAGES | ||
| | Intents.MESSAGE_CONTENT | ||
| | Intents.GUILD_MEMBERS | ||
| | Intents.GUILDS | ||
| ) |
There was a problem hiding this comment.
Why are these intents different from the ones in the Crescent bot?
There was a problem hiding this comment.
Because for prefix commands to work, ALL_MESSAGES and MESSAGE_CONTENT was necessary, but since I'll be removing prefix commands I'll remove those intents too
| hikari-lightbulb~=2.2.0 | ||
| hikari-tanjun~=2.9.0 |
There was a problem hiding this comment.
| hikari-lightbulb~=2.2.0 | |
| hikari-tanjun~=2.9.0 | |
| hikari-lightbulb>=2.2.0,<3.0 | |
| hikari-tanjun>=2.9.0,<3.0 |
It may be worth opening these constraints up to accept future updates like Crescent does.
I think it might make the guide a bit too cluttered, so I was going to stick with slash commands only after some consideration |
Okay cool, that sounds good to me. |
Various updates to examples, including