draft(optimism): sendRawTransactionConditional #13926
Open
+104
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
A-block-building
mattsse
requested changes
Jan 23, 2025
| @@ -10,6 +10,10 @@ pub struct RollupArgs { | |||
| #[arg(long = "rollup.sequencer-http", value_name = "HTTP_URL")] | |||
| pub sequencer_http: Option<String>, | |||
|
|
|||
| /// Enable transaction conditional support on sequencer | |||
| #[arg(long = "rollup.sequencer-transaction-conditional-enabled", default_value = "false")] | |||
There was a problem hiding this comment.
let's rename this to enable-transaction-conditional
Comment on lines
+54
to
+55
| /// Indiciator if this transaction has been marked as rejected | ||
| rejected: AtomicBool // (is AtomicBool appropriate here?) |
There was a problem hiding this comment.
we can remove this for now, because we'll handle eviction differently
|
|
||
| /// Optional conditional attached to this transaction. Is this | ||
| /// needed if this field is on OpTransactionSigned? | ||
| conditional: Option<TransactionConditional>, |
There was a problem hiding this comment.
yes we need this field here.
this option is also fine because this tx type is always wrapped in an Arc so it's always on the heap anyway
Comment on lines
+48
to
+50
|
|
||
| /// Can we attach a conditional the moment a transaction is deserialized? | ||
| pub conditional: Option<TransactionConditional> |
There was a problem hiding this comment.
this we shouldn't do, because this is a representation fo the actual tx type and shouldn't be annotated with out of protocol data
| } | ||
|
|
||
| // TEMPORARY since TransactionConditional does not impl eq |
There was a problem hiding this comment.
mind submitting a pr on alloy for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving a few comments in the different places that might require changes. Will flesh out an implementation after a soft approval/guidance in the right direction
OpTransactionSigned/OpPooledTransaction. References toconditionaland notion ofrejectedOpTransactionSigned. We need reference to the conditional to validate duringexecute_best_transactionsand a means to invalidate from the pool.L2EthApiExt&OpTransactionSigned: Can the conditional be attached as an optional field on the deserialized tx? This waypool::add_transactionis simply used. Or should a pool wrapper have a separate interface for submission.PoolWrapper -> If we wrap the
Poolinterface, should this filter out the rejected txs and in a background task remove them from the pool?validate_onewhich would duplicate the conditional checks