Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): setters for TransportRpcModules #13773

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

rkrasiuk
Copy link
Member

Description

Currently, it's not possible to call RpcServerConfig::start without initializing the registry, because there is no way to configure TransportRpcModules without it. This PR adds setters for TransportRpcModules.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jan 11, 2025
@rkrasiuk rkrasiuk enabled auto-merge January 11, 2025 13:52
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc nit

crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk requested a review from mattsse January 11, 2025 15:23
@rkrasiuk rkrasiuk added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit 6ef86e9 Jan 11, 2025
43 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/rpc-transport-rpc-modules-setters branch January 11, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants