perf: warm transactions in parallel #13759
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
DaniPopes
reviewed
Jan 11, 2025
Comment on lines
+2293
to
+2294
| caches.clone(), | ||
| cache_metrics.clone(), |
There was a problem hiding this comment.
Is the cache state shared on clone?
| ); | ||
|
|
||
| // TODO: move this logic somewhere better? | ||
| for tx in block.body().transactions() { |
There was a problem hiding this comment.
you could wrap the entire thing in pool.scope(|s| ) to avoid cloning but then it would block at scope end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for spawning tx prewarm threads on a dedicated threadpool, similar to the state root task threadpool
Currently blocked, we need to be able to split an existing block into many execution inputs
ref #13713