Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more impls for OpTransactionSigned #13546

Merged
merged 3 commits into from
Dec 24, 2024
Merged

feat: add more impls for OpTransactionSigned #13546

merged 3 commits into from
Dec 24, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 24, 2024

Adds Compact and SerdeBincodeCompat impls for OpTransactionSigned

Rjected
Rjected approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, needed before switching out primitives

@klkvr klkvr added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit c6e38be Dec 24, 2024
43 checks passed
@klkvr klkvr deleted the klkvr/impl-for-op-tx branch December 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @Rjected