refactor(source): extract concurrency checks and rpc fetches into separate Fetcher
struct
#58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now semaphore and rate-limiting code is spread and duplicated all over the code-base, some calls to rpc methods are actually missing them.
Solution
Create a wrapper for
Provider
that centralized all rpc accesses and makes sure concurrency controls are applied to all of them.In future this might also allow easy introduction of re-tries in presence of network or transient target endpoint errors.
It's probably possible to make
Fetcher
implementMiddleware
trait and maybe reduce a bit some of the function signature changes, but at the moment this seemed easier and ensures all used rpc methods properly follows concurrency checks without overriding all middleware functions.PR Checklist