Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3x.yml #2653

Draft
wants to merge 10 commits into
base: 3.x
Choose a base branch
from
3 changes: 2 additions & 1 deletion .github/workflows/3x.yml
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ jobs:
strategy:
matrix:
operating-system: [ 'macos-latest' ]
php-versions: [ '7.4', '8.2', '8.3' ]
php-versions: [ '7.4', '8.0', '8.4' ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php-versions: [ '7.4', '8.0', '8.4' ]
php-versions: [ '7.4', '8.1', '8.4' ]

8.0 is EoL

max-parallel: 1
env:
TERMINUS_TOKEN: ${{ secrets.TERMINUS_TOKEN }}
@@ -76,6 +76,7 @@ jobs:
TERMINUS_VERIFY_HOST_CERT: ${{ vars.TERMINUS_VERIFY_HOST_CERT }}
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1
HOMBEBREW_NO_AUTO_UPDATE: 1
TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't set this in CI, update wherever those supported values are set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was just to surface errors in this PR to address them later. But I've failed to do so 😂 I guess we will wait until we actually prioritize a ticket to provide this support :)

needs: [ checkout_build ]
steps:
- name: Install SSH key
1 change: 1 addition & 0 deletions phpunit.xml
Original file line number Diff line number Diff line change
@@ -33,5 +33,6 @@
<server name="TERMINUS_CACHE_DIR" value="${TERMINUS_CACHE_DIR}" />
<server name="TERMINUS_DEBUG" value="${TERMINUS_DEBUG}" />
<server name="TERMINUS_PROJECT_ROOT" value="${TERMINUS_PROJECT_ROOT}" />
<server name="TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP" value="${TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP}" />
</php>
</phpunit>
Loading