Add build-env:create-project command #3

greg-1-anderson · 2017-01-31T04:29:06Z

Ported from https://github.com/stevector/pantheon-create-project.

See #7

stevector · 2017-01-31T17:33:03Z

@greg-1-anderson, shall we bring over the circle.yml pieces so that this functionality itself can be tested? We'd need a new github user like the @stevectorbot account I used over in https://github.com/stevector/pantheon-create-project

greg-1-anderson · 2017-01-31T17:46:44Z

Yes, I think it would be a good idea to have some circle tests that use create-project to clone pantheon-systems/example-drops-8-composer and set up new GitHub, Pantheon and Circle projects with the create-project command.

It would probably be too meta to submitting a PR to the new GitHub account and hang out until the test passed. However, I think we could test the other commands in this tool by directly creating a multidev account and walking through all of the steps that the example.circle.yml does, and confirm the results.

greg-1-anderson · 2017-01-31T17:48:32Z

Note also, though, that this PR is still a little ways from "done". There are a couple entire methods that still need to be ported from bash, and there are some variables that are not calculated &/or passed all the way through to the methods that use them. None of this code has been executed yet.

stevector · 2017-01-31T18:03:25Z

Sounds good, let know if you want to talk through any of the pieces.

stevector · 2017-02-16T01:09:07Z

@greg-1-anderson, it worked for me too!

https://github.com/stevector/pantheon-create-project/pull/8/files
https://circleci.com/gh/stevector/pantheon-create-project/40
https://circleci.com/gh/stevectorbot/stevectorbot-40/tree/master

stevector · 2017-02-16T01:09:55Z

src/Commands/BuildToolsCommand.php

+
+        // Create a new README file to point to this project's Circle tests and the dev site on Pantheon
+        $circleBadge = "[![CircleCI](https://circleci.com/gh/$source.svg?style=svg)](https://circleci.com/gh/{$target_project})";
+        $pantheonBadge = "[![Pantheon {$target}](https://img.shields.io/badge/pantheon-{$target}-yellow.svg)](https://admin.dashboard.pantheon.io/sites/{$site_uuid}#dev/code)";


This command use the regular dashboard instead of the admin dashboard.

Yeah, you're right. Thanks.

stevector · 2017-02-16T01:10:29Z

src/Commands/BuildToolsCommand.php

+        // Create a new README file to point to this project's Circle tests and the dev site on Pantheon
+        $circleBadge = "[![CircleCI](https://circleci.com/gh/$source.svg?style=svg)](https://circleci.com/gh/{$target_project})";
+        $pantheonBadge = "[![Pantheon {$target}](https://img.shields.io/badge/pantheon-{$target}-yellow.svg)](https://admin.dashboard.pantheon.io/sites/{$site_uuid}#dev/code)";
+        $siteBadge = "[![Dev Site {$target}](https://img.shields.io/badge/site-{$target}-blue.svg)](http://dev-{$target}.pantheonsite.io/)";


Two of the generated shields failed here: https://github.com/stevectorbot/stevectorbot-40

I guess you cannot have dashes in the badge text. Will need to decide what to do about that.

Converting dashes to underscores works--although underscores render as spaces, it's probably close enough for badge purposes.

stevector · 2017-02-16T19:53:33Z

@greg-1-anderson, we'll need to decide how to handle sites that don't have access to multidev.

greg-1-anderson · 2017-02-16T20:17:29Z

@stevector The original template site README advises to switch to dev for everything by editing your circle.yml. We could auto-degrade to that on site creation if multidev was not available.

Do you happen to know how to detect multi-dev capable sites via Terminus? We could check the service level via terminus site:info, and hardcode the non-multi-dev service levels if there is nothing more direct.

stevector · 2017-02-17T14:48:32Z

I'd really rather not try to rely on service level since we have so many Sandbox testing sites that we've manually flipped to multidev. I don't see a Terminus command for this specifically but I'm sure one could be written.

greg-1-anderson · 2017-02-17T18:12:32Z

Is there any sort of web service API or other way to remotely detect if multidev is available? As a fallback, we could try to create one, but that would be slow and inelegant.

greg-1-anderson · 2017-02-17T19:04:18Z

Maybe the best thing to do, failing an infallible way to detect multidev capability, would be to have an option to select whether the user wishes to use multidev or not. We could perhaps use the service level to provide the default value if the user does not explicitly specify it.

stevector · 2017-02-28T17:53:40Z

src/Commands/BuildToolsCommand.php

+        $target_project = "$target_org/$target";
+        $remote_url = "[email protected]:${target_project}.git";
+
+        $branch = ''; // TODO: allow non-master here?


Yes, I was talking with an agency today about Lightning. It'd be nice to run this command against https://github.com/pantheon-systems/example-drops-8-composer/pull/33/files

I think that would be pantheon-systems/example-drops-8-composer:dev-lightning-fist-2.

stevector · 2017-02-28T17:54:58Z

src/Commands/BuildToolsCommand.php

+        $remote_url = "[email protected]:${target_project}.git";
+
+        $branch = ''; // TODO: allow non-master here?
+        $version = ''; // TODO: allow version selection here? (e.g. '~2' or '^1.5')


We could just have $source_project be passed in fully formed rather than construct it from multiple variables

Yeah, I was thinking about going that route too. Sounds like a good plan.

greg-1-anderson · 2017-02-28T18:57:10Z

@stevector I pushed a commit to allow org/project:dev-branch, but I haven't tested it yet.

stevector · 2017-02-28T21:45:02Z

src/Commands/BuildToolsCommand.php

+        // Set the target environment to sftp mode prior to installation
+        $this->connectionSet($env, 'sftp');
+
+        $command_line = "drush site-install --yes";


I made this branch a month ago but forgot to open the PR apparently: pantheon-systems/example-drops-8-composer#60

Different repos (WordPress, Acquia Lightning, etc) may have totally different install steps. I think we should let the given repo provide its own CMS installation instructions.

greg-1-anderson · 2017-03-03T05:53:39Z

OMG passing tests! With Circle CI inception!

…erate commands.

…d-env:merge wait for the code sync to finish before exiting, to avoid follow-on calls to the merge target from failing.

…t in build-env:merge. Delete .git directories before running 'git add'.

greg-1-anderson · 2017-03-11T18:28:50Z

I'm going to merge this PR as an EXPERIMENTAL feature; backwards compatibility is not guaranteed until the command is completed, at which point I will tag version 1.3.0. This will make it easy for folks to try this command, while still giving us the latitude to make breaking changes to get the API / options right.

greg-1-anderson changed the title ~~Rough-out a create-project command~~ Add build-env:create-project command Feb 15, 2017

stevector reviewed Feb 16, 2017

View reviewed changes

greg-1-anderson force-pushed the create-project branch from 2823ed6 to 778b88d Compare February 21, 2017 22:48

greg-1-anderson referenced this pull request in podllc/drupal-starter-pantheon Feb 27, 2017

MIT license.

31baab2

stevector reviewed Feb 28, 2017

View reviewed changes

greg-1-anderson force-pushed the create-project branch from 6a3e2c8 to 8af84dc Compare March 2, 2017 03:23

greg-1-anderson force-pushed the create-project branch 2 times, most recently from 30e4123 to 079236d Compare March 7, 2017 18:12

Add build-env:create-project, build-env:push-code and build-env:oblit…

1815d95

…erate commands.

greg-1-anderson force-pushed the create-project branch from 079236d to 1815d95 Compare March 7, 2017 23:06

greg-1-anderson added 4 commits March 7, 2017 16:07

Refresh Pantheon remote on every call to build-env:create. Make buill…

a39b464

…d-env:merge wait for the code sync to finish before exiting, to avoid follow-on calls to the merge target from failing.

Wait for the code sync before deleting the unused multidev environmen…

2dc2f54

…t in build-env:merge. Delete .git directories before running 'git add'.

Fix siteHasMultidevCapability: max_num_cdes moved to 'settings'.

efc0449

Fix typo in siteHasMultidevCapability().

766b7e9

greg-1-anderson merged commit 766b7e9 into master Mar 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add build-env:create-project command #3

Add build-env:create-project command #3

greg-1-anderson commented Jan 31, 2017 •

edited

Loading

stevector commented Jan 31, 2017

greg-1-anderson commented Jan 31, 2017

greg-1-anderson commented Jan 31, 2017

stevector commented Jan 31, 2017

stevector commented Feb 16, 2017

stevector Feb 16, 2017

greg-1-anderson Feb 16, 2017

stevector Feb 16, 2017

greg-1-anderson Feb 16, 2017

greg-1-anderson Feb 16, 2017

stevector commented Feb 16, 2017

greg-1-anderson commented Feb 16, 2017

stevector commented Feb 17, 2017

greg-1-anderson commented Feb 17, 2017

greg-1-anderson commented Feb 17, 2017

stevector Feb 28, 2017

greg-1-anderson Feb 28, 2017 •

edited

Loading

stevector Feb 28, 2017

greg-1-anderson Feb 28, 2017

greg-1-anderson commented Feb 28, 2017

stevector Feb 28, 2017

greg-1-anderson commented Mar 3, 2017

greg-1-anderson commented Mar 11, 2017

Add build-env:create-project command #3

Add build-env:create-project command #3

Conversation

greg-1-anderson commented Jan 31, 2017 • edited Loading

stevector commented Jan 31, 2017

greg-1-anderson commented Jan 31, 2017

greg-1-anderson commented Jan 31, 2017

stevector commented Jan 31, 2017

stevector commented Feb 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevector commented Feb 16, 2017

greg-1-anderson commented Feb 16, 2017

stevector commented Feb 17, 2017

greg-1-anderson commented Feb 17, 2017

greg-1-anderson commented Feb 17, 2017

Choose a reason for hiding this comment

greg-1-anderson Feb 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg-1-anderson commented Feb 28, 2017

Choose a reason for hiding this comment

greg-1-anderson commented Mar 3, 2017

greg-1-anderson commented Mar 11, 2017

greg-1-anderson commented Jan 31, 2017 •

edited

Loading

greg-1-anderson Feb 28, 2017 •

edited

Loading