Ignore PHP errors related to the version being run #12
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue that is likely coming from PHPCompatibility or PHPCompatibility-WP. The issue was present in WPCS (but fixed in 3.0). There is no real benefit for leaving error reporting in when it has to do with a CS ruleset, so I think we can safely just ignore errors. See: WordPress/WordPress-Coding-Standards#2035 See also: https://gist.github.com/shreyasikhar/f4495ac952586096eb81d505e9e914a4
|
Per the linked issues is this not resolved with 3.0? Where is this cropping up? |
|
@pwtyler I saw it on my own site that was using the standard. I think it's coming from |
|
An alternative solution to this would be to (likely) require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue that is likely coming from PHPCompatibility or PHPCompatibility-WP. The issue was present in WPCS (but fixed in 3.0). There is no real benefit for leaving error reporting in when it has to do with a CS ruleset, so I think we can safely just ignore errors.
See: WordPress/WordPress-Coding-Standards#2035
See also: https://gist.github.com/shreyasikhar/f4495ac952586096eb81d505e9e914a4