Add redis #168
Closed
Add redis #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1603,6 +1613,22 @@ function terminus_notification_poll($site_uuid, $type) { | |||
| } | |||
| } | |||
|
|
|||
| /* Add Redis */ | |||
| function drush_terminus_pantheon_site_redis_add($site_uuid) { | |||
There was a problem hiding this comment.
Let's call it "enable" instead of "add".
Let's split this out into three functions:
drush_termins_pantheon_site_redis_enable_validate() - validates input, like we do for other functions
drush_termins_pantheon_site_redis_enable() - gives the user some output, and calls
terminus_api_site_redis_enable() (in termins.site.api.inc) that takes valid input and calls terminus_request()
|
@joshkoenig Nice timing on the validation helper functions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I check to see if Redis is already enabled?
Fixes GH-163
/fu