make construct use category a String? instead of a list, set it to PO… #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S for vocab constructs
wcjord
requested changes
Nov 1, 2024
|
|
||
| factory ConstructIdentifier.fromJson(Map<String, dynamic> json) { | ||
| final categoryEntry = json['cat']; |
There was a problem hiding this comment.
I think we want json['cat'] ?? json ['categories'] for backwards compatibility here.
There was a problem hiding this comment.
Need to add to the ContructIdentifier toJson as well!
| @@ -134,7 +142,7 @@ class OneConstructUse { | |||
| data['constructType'] = constructType.string; | |||
|
|
|||
| if (id != null) data['id'] = id; | |||
| data['categories'] = categories; | |||
| data['categories'] = category; | |||
| return OneConstructUse( | ||
| useType: ConstructUseTypeUtil.fromString(json['useType']), | ||
| lemma: json['lemma'], | ||
| form: json['form'], | ||
| categories: json['categories'] != null |
There was a problem hiding this comment.
Same thing here of json['cat'] ?? json['categories']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…S for vocab constructs
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Please make sure that your Pull Request meet the following acceptance criteria:
dart format lib/ test/anddart run import_sorter:main --no-commentsPull Request has been tested on: