Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix word sticking together, finally 🤯 #893

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

WilsonLe
Copy link

@WilsonLe WilsonLe commented Nov 1, 2024

Testing steps to ensure it's fixed:

  • Obtain a message that has the following format "A bunch of text, 🥲 then emojis in between, 🤯 then more texts". A reliable method to achieve this kind of message is as follow:
    • Create chat group
    • Invite bot in discussion mode
    • React the ⏩ icon in bot join message
    • It should send a message with the desired format
  • Click on the message to trigger practice activities
  • The message should not be sticking together

@WilsonLe WilsonLe linked an issue Nov 1, 2024 that may be closed by this pull request
@WilsonLe WilsonLe requested a review from ggurdin November 1, 2024 04:52
@WilsonLe
Copy link
Author

WilsonLe commented Nov 1, 2024

Dev notes:

🚀 <-- escaping this is something like "\a123\a321"
we were substring-ing the pair \a123\a321 into 2 so called strings \a123 and \a321, which make flutter freaks out

I installed a package that checks if we are substringing a pair of those that we are not supposed to. It's similar to python's grapheme package but for flutter

@ggurdin ggurdin merged commit 584dc94 into main Nov 1, 2024
2 of 5 checks passed
@ggurdin ggurdin deleted the 730-fix-accept-replacement branch November 1, 2024 14:00
@ggurdin ggurdin linked an issue Nov 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Words sticking together in overlay Fix accept replacement
2 participants