Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits extensions into multiple smaller files #242

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

Kelrap
Copy link
Collaborator

@Kelrap Kelrap commented May 24, 2024

Splits client_extension and pangea_room_extension into multiple smaller files

@ggurdin
Copy link
Collaborator

ggurdin commented May 27, 2024

@Kelrap These look great! Can you rename the new files to make it clear that they're extensions (i.e., client_analytics_extension.dart and room_analytics_extension.dart), and move client_extension.dart and pangea_room_extension.dart to their respective folders?

@ggurdin
Copy link
Collaborator

ggurdin commented May 27, 2024

Hey, I'm getting some import errors now.
Screenshot 2024-05-27 at 3 49 44 PM
Also, can you give the extension more specific names, i.e. "AnalyticsClientExtension" instead of "PangeaClient1"

@ggurdin ggurdin merged commit 7a43706 into main Jun 3, 2024
4 of 5 checks passed
@ggurdin ggurdin deleted the reorganize-extensions branch June 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants