feat: gas optimization #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefSnoopy
previously approved these changes
Apr 26, 2024
ChefMist
changed the title
reserveOfVault
ChefMist
changed the title
reserveOfVault 
|
It seems that we only need to merge the PR 33 , and then don not need this PR ? |
we can assume #33 to a POC and won't be merge anytime soon (theres still test required and merge conflict to resolve) -- where this PR have gas optimization around the repository so the flow would be to merge this PR first and eventually see when we merge PR #33 |
ChefSnoopy
previously approved these changes
May 7, 2024
|
Not urgent... It just hit me that maybe we need to update the Invariant test to cover the native token case
|
|
created #37 to track this 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gas optimization
reservesOfVaultno longer tracking eth balancepoolId.toId()