Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pcsx jan 10 #11131

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat/pcsx jan 10 #11131

wants to merge 2 commits into from

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Jan 13, 2025


PR-Codex overview

This PR focuses on enhancing the ExclusiveDutchOrder class by adding a quoteId property, improving trade handling in the useBestTradeFromApi hook, and streamlining various API interactions for better performance and reliability.

Detailed summary

  • Added quoteId property to ExclusiveDutchOrder.
  • Updated the order.info.quoteId assignment in orderPriceApiParsers.ts.
  • Modified useBestTradeFromApi to improve conditional logic and refactor API calls.
  • Removed useBestTradeFromApiShadow function.
  • Introduced fetchPoolsForApi and fetchAndParseAMMPriceResponse functions for better API handling.
  • Enhanced performance tracking with additional logging.
  • Cleaned up imports and removed unused code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 5cb9432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:44am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:44am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 0:44am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blog ⬜️ Ignored (Inspect) Jan 13, 2025 0:44am
bridge ⬜️ Ignored (Inspect) Jan 13, 2025 0:44am
games ⬜️ Ignored (Inspect) Jan 13, 2025 0:44am
uikit ⬜️ Ignored (Inspect) Jan 13, 2025 0:44am
ton ⬜️ Skipped (Inspect) Jan 13, 2025 0:44am

@@ -591,6 +581,7 @@ export function useBestTradeFromApi({

const previousEnabled = usePreviousValue(enabled)

console.log('enabled', enabled)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants