Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add concurrency to build and add terser minify #11123

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 8, 2025


PR-Codex overview

This PR primarily updates the devDependencies in various package.json and tsconfig.json files, adds exclusions for test files and node modules, and introduces concurrency options in build scripts. It also updates the debug package and refines several dependencies.

Detailed summary

  • Added start-server-and-test to devDependencies in apps/e2e/package.json.
  • Updated tsconfig.json files to exclude node_modules, test files, and dist directories.
  • Included include paths for source directories in tsconfig.json files.
  • Modified build scripts in package.json to include concurrency options.
  • Updated debug package version across various files.
  • Removed @gnosis.pm/safe-apps-wagmi from apps/web/package.json.
  • Various dependency version updates in pnpm-lock.yaml.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 21fef9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 8:02am

Copy link

socket-security bot commented Jan 8, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment 0 1.03 MB vercel-release-bot

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jan 8, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫

View full report↗︎

Next steps

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant