Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merkl link for pools with reward on different chain #11093

Merged

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Dec 26, 2024


PR-Codex overview

This PR updates the merklPools.json configuration and refines the parseMerklConfig function to handle a new structure for the Merkl configuration response. It also corrects the chainId values and updates the links to reflect the Ethereum network.

Detailed summary

  • Updated chainId from 1923 to 1 in merklPools.json.
  • Changed pool links to use "ethereum" instead of "undefined".
  • Refined parseMerklConfig function to accept MerklConfigResponse instead of an array.
  • Adjusted the way pools are processed, now mapping chainId correctly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 2:41pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
blog ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
bridge ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
games ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
gamification ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
uikit ⬜️ Ignored (Inspect) Visit Preview Dec 26, 2024 2:41pm
ton ⬜️ Skipped (Inspect) Dec 26, 2024 2:41pm

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 86d21b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Chef-Yogi Chef-Yogi merged commit 0d39c48 into develop Dec 26, 2024
21 checks passed
@Chef-Yogi Chef-Yogi deleted the feature/fix_merkl_link_for_pools_with_different_chain branch December 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants