fix: No active position shown when loading lp positions #11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
|
memoyil
force-pushed
the
feature/fix_no_active_position_shown_when_loading
branch
from
ec50ecc to
b69d77b
Compare
memoyil
force-pushed
the
feature/fix_no_active_position_shown_when_loading
branch
from
b69d77b to
47902aa
Compare
Chef-Yogi
approved these changes
Jan 3, 2025
Chef-Yogi
deleted the
feature/fix_no_active_position_shown_when_loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user only has the positions in either of them (v3,v2,stable), no active position for a period of time shown if the type where there is no position loaded first
PR-Codex overview
This PR enhances the loading state management in the
PositionPagecomponent by checking loading flags before rendering the empty state and modifies how loading indicators are displayed.Detailed summary
v3Loading,v2Loading,stableLoading) before rendering the empty state.<PositionItemSkeleton />) and a loading text indicator when any of the position lists are loading.elementsfor better readability.