feat: assume trust of protocol fee controller #223
Conversation
|
| File | % Lines | % Statements | % Branches | % Funcs | |
src/ProtocolFees.sol
Outdated
| @@ -11,6 +11,7 @@ import {PoolKey} from "./types/PoolKey.sol"; | |||
| import {PoolId} from "./types/PoolId.sol"; | |||
| import {IVault} from "./interfaces/IVault.sol"; | |||
| import {BipsLibrary} from "./libraries/BipsLibrary.sol"; | |||
There was a problem hiding this comment.
Can remove BipsLibrary and "using BipsLibrary for uint256;" now
src/ProtocolFees.sol
Outdated
| address targetProtocolFeeController = address(protocolFeeController); | ||
| bytes memory data = abi.encodeCall(IProtocolFeeController.protocolFeeForPool, (key)); | ||
|
|
||
| bool success; | ||
| uint256 returnData; | ||
| assembly ("memory-safe") { | ||
| // only load the first 32 bytes of the return data to prevent gas griefing | ||
| success := call(controllerGasLimit, targetProtocolFeeController, 0, add(data, 0x20), mload(data), 0, 32) | ||
| success := call(gas(), targetProtocolFeeController, 0, add(data, 0x20), mload(data), 0, 32) | ||
| // if success is false this wont actually be returned, instead 0 will be returned |
There was a problem hiding this comment.
need to edit this comments , will revert with "ProtocolFeeCannotBeFetched" , not 0
Context
Currently pool initialization requires a buffer of
1% of block.gasLimit. This means that for BNB chain (with 100m gas), it require user to allocate > 1mil in gas.Problem: This result in integrator asking why do they need so much gas to initialize a pool.
Also:
Description
This PR assume the trust of protocol fee controller. When integrator try to initialize a pool, they will not need to specify the 1 million buffer.
Now
Previously
1% of block.gasLimit