Gravity Rewrite #964
Gravity Rewrite #964
Conversation
* We are only dealing with ugrain, but we have different chains. Modifying the request to allow for this, and leaving it a bit hacky for now. Will revisit * We don't care about how profitable a batch is, we want to always allow creating a new batch * When a new batch is requested but there aren't any transactions, just do nothing. This isn't an error, so don't return an error * Set the gravity salt for signing to be something other than the default in genesis
… into one commit * Remove valset pieces and rely on existing valset in Paloma * Remove orchestrator setting and rely on EVM implementation for getting eth keys * Remove lots of other things that existed in Gravity that we don't need, like deploying ERC20s, logic calls, blacklisting, bridge halting. * Set up the turnstone ID from the smart contract to use for signing * Fix all the tests that broke from doing all the above * Add some cli commands to investigate what is going on with batches * Batch up transactions every 50 blocks * Assign batches to pigeons using out assignment logic * Rewrite a lot of code that overly utilized panic(). When we panic on one host, we risk a different app hash * Allow sending our coin (GRAIN) to any chain. We keep track of the token on that chain and can send it to any chain that has a token. This mapping is controlled by governance * Remove fees. This will be handled elsewhere
There was a problem hiding this comment.
This PR is simply too large to be reviewed sensibly, it's impossible to tell which part are custom adaptions and which is directly taken from the original gravity module.
To be honest, I think we'd be going back and forth for a week or two defining common coding guidelines for the Paloma project and bringing everything up to par. It's something I'd like to do given the time to reduce the clutter from merging in foreign code, but it will completely kill project velocity.
|
I've added the migration to this. The module name needed to be changed to "gravity2" because the "gravity" stores changed so much, and we can't delete and add in the same migration. We can rename the module to "gravity" in a later migration if we choose. The upgrade path has been tested and works. This can be merged |
|
merged |
Related Github tickets
Background
A complete rewrite of Gravity to use the functionality from Gravity-Bridge instead of PeggyJV
This strips down the unneeded functionality from Gravity and only includes the parts we need.
I have also removed duplicate functionality for things like valset and validator eth address lookups. We rely on our existing workflows for those.
The new functionality here includes:
I'm opening this as draft for now. It's a huge amount of code. The best way to test it is likely to stand it up in the private testnet and verify that everything works as expected.
Testing completed
Breaking changes