Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy user smart contracts #1200

Merged
merged 27 commits into from
Aug 22, 2024
Merged

feat: deploy user smart contracts #1200

merged 27 commits into from
Aug 22, 2024

Conversation

maharifu
Copy link
Contributor

@maharifu maharifu commented Jun 25, 2024 •
edited
Loading

Related Github tickets

Background

Deploy any smart contract to any supported Paloma chain via the CLI using the Pigeon Feed functionality for paying for message relays.

The PR adds a CLI interface to interact with user-defined smart contracts:

  • Upload new contract to Paloma. The contract will be available to be deploy in any of our target chains.
  • List contracts. Users can see their contracts and deployment status, as well as target addresses when successfully deployed.
  • Remove contract. Delete the contract from Paloma.
  • Deploy contract. Trigger deployment of a previously uploaded smart contract to any of our target chains.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu marked this pull request as draft June 25, 2024 14:54
byte-bandit
byte-bandit reviewed Jun 26, 2024
View reviewed changes
x/evm/types/keys.go Outdated Show resolved Hide resolved
@maharifu maharifu force-pushed the lcarvalho/159-deploy-smart-contracts branch from e9f3a3f to f2915b2 Compare June 26, 2024 14:30
byte-bandit
byte-bandit previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

proto/palomachain/paloma/evm/turnstone.proto Outdated Show resolved Hide resolved
proto/palomachain/paloma/evm/tx.proto Show resolved Hide resolved
@maharifu maharifu force-pushed the lcarvalho/159-deploy-smart-contracts branch 3 times, most recently from a30d8b3 to fd7a594 Compare August 20, 2024 09:33
@maharifu maharifu changed the title Lcarvalho/159 deploy smart contracts feat: deploy user smart contracts Aug 21, 2024
@maharifu maharifu marked this pull request as ready for review August 21, 2024 16:07
@maharifu maharifu mentioned this pull request Aug 21, 2024
Merged
3 tasks
byte-bandit
byte-bandit reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff and great call on the fee abstraction. Some remarks, mostly about the proposal type.

proto/palomachain/paloma/evm/set_smart_contract_deployer_proposal.proto Outdated Show resolved Hide resolved
proto/palomachain/paloma/evm/user_smart_contract.proto Outdated Show resolved Hide resolved
x/evm/client/cli/tx_proposal.go Show resolved Hide resolved
x/evm/keeper/attest_upload_user_smart_contract.go Outdated Show resolved Hide resolved
x/evm/types/turnstone_abi.go Outdated Show resolved Hide resolved
@maharifu
chore: use msgServer instead of Keeper in evm
677193d
@maharifu
chore: smart contract status in line with compass
ccaac8b
@maharifu
chore: validate smart contract before saving
1d6e648
@maharifu
chore: validate chain on smart contract deployment
b800abb
@maharifu
chore: get valAddress from creator
c8651f1
@maharifu
chore: use proper prefix stores for smart contract
7f55904
@maharifu
chore: support multiple deployments to same chain
253dac8
@maharifu
chore: purge stale user smart contracts
4f7f176
@maharifu
chore: change ValAddress to Author
ae7f2d5
@maharifu
fix: validator pick and tests
37c7558
@maharifu
chore: add set smart contract deployer gov vote
9ee1fee
@maharifu
chore: update user smart contract structure
28ff616
@maharifu
chore: add fees to Upload User Smart Contracts
81d9318
@maharifu
chore: verify TX for user smart contracts
3080ba7
@maharifu
chore: fix upload smart contract tx verify
d4ed8cb
@maharifu
chore: add serializedReceipt to tx proof
7eb600d
@maharifu
chore: add contract address from tx events
1ba0fb7
@maharifu
chore: extract default fees to own function
6652556
@maharifu
chore: fix typo
c8b9126
@maharifu
chore: nest deployment status enum
de84c86
@maharifu
chore: set all deployer addresses in 1 proposal
422f02d
@maharifu maharifu force-pushed the lcarvalho/159-deploy-smart-contracts branch from 8ffbc4a to 422f02d Compare August 22, 2024 12:49
@maharifu maharifu merged commit 5baf5f2 into palomachain:master Aug 22, 2024
4 checks passed
@maharifu maharifu deleted the lcarvalho/159-deploy-smart-contracts branch August 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byte-bandit byte-bandit byte-bandit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maharifu @byte-bandit