Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: adding a favicon #2562

Closed
wants to merge 6 commits into from
Closed

Docs: adding a favicon #2562

wants to merge 6 commits into from

Conversation

ElLorans
Copy link
Contributor

@ElLorans ElLorans commented Nov 2, 2024

Added section to the docs; changed example to use redirect in place of send_file.

@ElLorans
Docs: adding a favicon
11bc145
@ElLorans
Examples use redirect
ec77002 
Best practices: redirect(url_for()) in place of send_file
samuelhwilliams
samuelhwilliams approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@samuelhwilliams samuelhwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@samuelhwilliams
Copy link
Contributor

Please you could fix the styling issue, then happy to merge 👍

@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Nov 3, 2024 •
edited
Loading

p.s. I would recommend installing pre-commit and then you can either:

  • Install the hooks with pre-commit install --install-hooks so that they run automatically before every commit
  • Or do a one-off run with pre-commit run --all-files

Or you can run tox -e style to do it via tox.

@ElLorans ElLorans closed this by deleting the head repository Nov 3, 2024
@ElLorans
Copy link
Contributor Author

ElLorans commented Nov 3, 2024

Opened #2563 to have a clean commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelhwilliams samuelhwilliams samuelhwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElLorans @samuelhwilliams