Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy 2 installed by sqlalchemy1 tox factor #2540

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Oct 13, 2024

With use_frozen_constraints constraints are generated by calling "pip freeze" after the environment deps have been installed and before the package dependencies are installed, thus constraints-sqlalchemy1.txt is being ignored.


From #2518, but probably deserves it own PR.

From the logs for a sqlalchemy1 workflow run:

py312-sqlalchemy1: arrow==1.3.0,astroid==3.2.4,azure-common==1.1.28,azure-storage-blob==2.1.0,azure-storage-common==2.1.0,babel==2.16.0,beautifulsoup4==4.12.3,blinker==1.8.2,boto==2.49.0,certifi==2024.8.30,cffi==1.17.1,charset-normalizer==3.4.0,click==8.1.7,colour==0.1.5,coverage==7.6.1,cryptography==43.0.1,dill==0.3.8,dnspython==2.7.0,email_validator==2.2.0,exceptiongroup==1.2.2,flake8==7.1.1,Flask==3.0.3,Flask-Admin @ file:///home/runner/work/flask-admin/flask-admin/.tox/.tmp/package/1/flask_admin-2.0.0a0-py3-none-any.whl#sha256=be063b3a346085a903c97eec22d233cdf10ebac528d59793160728c057dfcfe5,flask-babel==4.0.0,Flask-SQLAlchemy==3.1.1,GeoAlchemy2==0.15.2,greenlet==3.1.1,idna==3.10,iniconfig==2.0.0,isort==5.13.2,itsdangerous==2.2.0,Jinja2==3.1.4,MarkupSafe==3.0.1,mccabe==0.7.0,numpy==2.1.2,packaging==24.1,peewee==3.17.6,pillow==10.4.0,pip==24.2,platformdirs==4.2.2,pluggy==1.5.0,psycopg2==2.9.9,pycodestyle==2.12.1,pycparser==2.22,pyflakes==3.2.0,pylint==3.2.7,pymongo==4.10.1,pytest==8.3.2,pytest-cov==5.0.0,python-dateutil==2.9.0.post0,pytz==2024.2,redis==5.1.1,requests==2.32.3,shapely==2.0.6,six==1.16.0,soupsieve==2.6,
SQLAlchemy==2.0.35

With use_frozen_constraints constraints are generated by calling "pip freeze"
after the environment deps have been installed and before the package
dependencies are installed, thus constraints-sqlalchemy1.txt is being ignored.
@samuelhwilliams
Copy link
Contributor

Feels like we should be able to have some better way of doing this .. feels like our tox/requirements set up is definitely not quite right 👀

@samuelhwilliams samuelhwilliams merged commit 0a34141 into pallets-eco:master Oct 14, 2024
12 checks passed
@cjmayo cjmayo deleted the tox-sqlalchemy1 branch October 15, 2024 18:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants