-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Bootstrap 5 #2432
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most layout settings are not corresponding to the design of Bootstrap5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also margins/paddings are not well structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also alert close button won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR pulls in a significant number of new files/amount of new code. Can you help me understand what is copy/paste and what is custom? Can you provide a script that pulls in the copy/paste-able static assets so that it's easier to validate what is provided as-is, and what is custom? This should help identify which areas to review more closely, and which are provided by bootstrap5 (and should theoretically have been critiqued already). |
|
Did anyone else try to use this change (Bs5) ? |
Could you add an example in the |
+1 |
+1 |
|
I wanted bootstrap 5 in my application, but flask-admin did not support it.
I have added bootstrap 5 support.
Use
template_mode='bootstrap5'
when callingAdmin()
app = Flask(__name__) app.config.from_object(Config) db.init_app(app) admin = Admin(app, name='Admin Interface', template_mode='bootstrap5')