-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AJAX and x-editable now allowed, plus uploading images to SQL database #2256
Open
mccarthysean
wants to merge
157
commits into
pallets-eco:master
Choose a base branch
from
mccarthysean:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccarthysean
force-pushed
the
master
branch
2 times, most recently
from
June 3, 2022 19:50
7839deb
to
a0f6dda
Compare
8 tasks
…lds in the list view The problem was we couldn't use AJAX and x-editable at the same time. Together they're awesome. AJAX-filled dropdowns make the list view page load MUCH faster, and x-editable fields greatly improve the user's editing experience in the list view. Now we can have both!
…file system It's more efficient to store images in the database, especially when storing image files in Docker images, which bloat the image size. This way our images can be stored and served from the SQL database as large binary files 👍
… images Added another example for users looking to use x-editable AJAX, or who want to upload their images to the database instead of the file system
Added NestedRuleClasses to add customizable classes, which allows Bootstrap containers, rows, and columns changed names for Bootstrap container, row, and col added example of Bootstrap container, row, and col
added 1rem of margin-right to the form buttons
…tstrap containers, rows, and columns
better margin below inline-field cards, and above inline-field buttons
… inline_models' "form_columns" Based on this error: https://stackoverflow.com/questions/34313253/flask-admin-inline-modelling-passing-form-arguments-throws-attributeerror
…n tuples. The next version of WTForms will abandon support for flags in tuples.
…n tuples. The next version of WTForms will abandon support for flags in tuples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: can't use AJAX and x-editable at the same time.
https://stackoverflow.com/questions/65193474/can-i-use-form-ajax-refs-and-column-editable-list-for-the-same-column-in-fla
Together they're awesome. AJAX-filled dropdowns make the list view page load MUCH faster, and x-editable fields greatly improve the user's editing experience in the list view.
Now we can have both!
Problem: can't save images to the database, only file system
It's more efficient to store images in the database, especially when storing image files in Docker images, which bloat the image size. This way, with the new "ImageUploadFieldDB" class, our images can be stored and served from the SQL database as large binary files 👍