Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize InternalSchemaMetadataPayloadCodec serDe #6739

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Optimize InternalSchemaMetadataPayloadCodec serDe #6739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...a/com/palantir/atlasdb/internalschema/persistence/InternalSchemaMetadataPayloadCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,17 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectReader;
import com.fasterxml.jackson.databind.ObjectWriter;
import com.google.common.collect.ImmutableMap;
import com.palantir.atlasdb.internalschema.InternalSchemaMetadata;
import com.palantir.conjure.java.serialization.ObjectMappers;
import com.palantir.logsafe.SafeArg;
import com.palantir.logsafe.exceptions.SafeIllegalStateException;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.StringReader;
import java.nio.charset.StandardCharsets;
import java.util.Optional;
import java.util.function.Function;

Expand All @@ -43,6 +48,8 @@ public final class InternalSchemaMetadataPayloadCodec {
ImmutableMap.of(LATEST_VERSION, InternalSchemaMetadataPayloadCodec::decodeViaJson);

private static final ObjectMapper OBJECT_MAPPER = ObjectMappers.newServerObjectMapper();
private static final ObjectReader SCHEMA_METADATA_READER = OBJECT_MAPPER.readerFor(InternalSchemaMetadata.class);
private static final ObjectWriter SCHEMA_METADATA_WRITER = OBJECT_MAPPER.writerFor(InternalSchemaMetadata.class);

private InternalSchemaMetadataPayloadCodec() {
// utility
Expand Down Expand Up @@ -85,7 +92,7 @@ static VersionedInternalSchemaMetadata encode(InternalSchemaMetadata internalSch
try {
return ImmutableVersionedInternalSchemaMetadata.builder()
.version(LATEST_VERSION)
.payload(OBJECT_MAPPER.writeValueAsBytes(internalSchemaMetadata))
.payload(SCHEMA_METADATA_WRITER.writeValueAsBytes(internalSchemaMetadata))
.build();
} catch (JsonProcessingException e) {
throw new RuntimeException(e);
Expand All @@ -94,7 +101,15 @@ static VersionedInternalSchemaMetadata encode(InternalSchemaMetadata internalSch

private static InternalSchemaMetadata decodeViaJson(byte[] byteArray) {
try {
return OBJECT_MAPPER.readValue(byteArray, InternalSchemaMetadata.class);
if (byteArray.length <= 8192) {
// Optimize to avoid allocation of heap ByteBuffer via InputStreamReader.
// Remove after upgrade to Jackson 2.16.
// see: https://github.com/FasterXML/jackson-core/pull/1081
// and https://github.com/FasterXML/jackson-benchmarks/pull/9
return SCHEMA_METADATA_READER.readValue(
new StringReader(new String(byteArray, StandardCharsets.UTF_8)));
}
return SCHEMA_METADATA_READER.readValue(new ByteArrayInputStream(byteArray));
} catch (IOException e) {
throw new RuntimeException(e);
}
Expand Down